-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix Split Scan flow for Group Chats #39276
Conversation
@fedirjh I will review this |
Code looks good and tests well. I will complete the checklist in an hour (having trouble uploading screenshots/videos) |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemweb-chrome.moviOS: Nativeios.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
@hayata-suenaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@marcaaron, also please complete the author checklist when you have time 😄 |
Quick update here. There was another issue so I fixed that one as well while I have this PR open. Small change here. |
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Oops didn't mean to trigger Melvin auto assignment. Sorry @cristipaval |
Updated and tested. There is still the question from @hayata-suenaga. I think it's ready for final review / merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix Split Scan flow for Group Chats (cherry picked from commit fdd075e)
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.58-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀
|
// If we do not have one locally then we will search for a chat with the same participants (only for 1:1 chats). | ||
const shouldGetOrCreateOneOneDM = participants.length < 2; | ||
if (!existingSplitChatReport && shouldGetOrCreateOneOneDM) { | ||
existingSplitChatReport = ReportUtils.getChatByParticipants(participantAccountIDs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this is supposed to behave. You can create multiple groups with the same users. If you create a split which of those existing group should be used?
cc @marcaaron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a new group is the expected behavior. The issue you linked is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FAB flows always create a new group now.
Details
@waterim @s77rt we missed a couple things. Split with a receipt should work now 🤞
Fixed Issues
$ #39254
$ #39249
$ #39247
Tests
Split scan with Group Chats
Group chat avatar does not lead to "not found" page
Confirm workspace avatar does not show for Group Chat
Offline tests
Repeat steps offline - verify same
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop